From 62efa0fadc3ef56999d29bad47cf3e71388d64d8 Mon Sep 17 00:00:00 2001 From: Marcus Netz Date: Tue, 24 Nov 2020 21:45:17 +0100 Subject: [PATCH] ReferenceError: msg is not defined --- src/commands/HeadsOrTails.js | 6 +- src/commands/attribute.js | 142 ++++++++++++++++++----------------- src/commands/index.js | 12 +-- src/commands/remove.js | 6 +- src/commands/roll.js | 29 +++---- src/commands/talent.js | 8 +- src/globals.js | 2 +- 7 files changed, 107 insertions(+), 98 deletions(-) diff --git a/src/commands/HeadsOrTails.js b/src/commands/HeadsOrTails.js index 78da1db..8814182 100644 --- a/src/commands/HeadsOrTails.js +++ b/src/commands/HeadsOrTails.js @@ -1,5 +1,5 @@ -const globals = require('../globals') +const globals = require('../globals'); module.exports = async (message, args, db) => { - let coin = Math.floor(Math.random()*2) - message.reply('Folgende Seite hat der Münzwurf ergeben: ' + globals.Coin[coin] + '.') + const coin = Math.floor(Math.random() * 2); + message.reply('Folgende Seite hat der Münzwurf ergeben: ' + globals.Coin[coin] + '.'); }; \ No newline at end of file diff --git a/src/commands/attribute.js b/src/commands/attribute.js index fa9622e..8873001 100644 --- a/src/commands/attribute.js +++ b/src/commands/attribute.js @@ -1,73 +1,79 @@ -const globals = require('../globals') +const globals = require('../globals'); module.exports = async (message, args, db) => { - try { - // user calls without arguments. - if (!args[0]) { - message.reply('Bitte gib mir ein Attributswert, oder das Attribut auf welches du würfeln möchtest.') - return - } - let level = 8 - let attributename + try { + // user calls without arguments. + if (!args[0]) { + message.reply('Bitte gib mir ein Attributswert, oder das Attribut auf welches du würfeln möchtest.'); + return; + } + let level = 8; + let attributename; - await db.find({ - user: message.author.tag, - }, async function (err, docs) { + await db.find({ + user: message.author.tag, + }, async function(err, docs) { - // user calls with text. need to gather info from database - if (isNaN(args[0])) { - if (!docs.length > 0) { - message.reply('Sorry, Für dich habe ich keinen Eintrag 😥\n' + + // user calls with text. need to gather info from database + if (isNaN(args[0])) { + if (!docs.length > 0) { + message.reply('Sorry, Für dich habe ich keinen Eintrag 😥\n' + 'Bitte gib mir den Attributswert, auf welchen du würfeln möchtest.'); - return - } else { - // try to get id of short formatted attributes. - if (args[0].length == 2) { - for (let i in globals.Werte) { - if (globals.Werte[i].kuerzel == args[0].toUpperCase()) attributename = globals.Werte[i].id; - } - } else { - attributename = args[0].toLowerCase(); - } - for (let i in docs[0].character.attributes) { - if (docs[0].character.attributes[i].id == attributename) level = docs[0].character.attributes[i].level; - } - } - } else { - level = args[0]; - } - const countOccurrences = (arr, val) => arr.reduce((a, v) => (v === val ? a + 1 : a), 0); - let dice = [] - dice.push(Math.floor(Math.random() * 20) + 1); - if (dice[0] == 1 || dice[0] == 20) { - dice.push(Math.floor(Math.random() * 20) + 1); - } - // handle crits - if (countOccurrences(dice, 1) == 2) { - message.reply('Du hast einen kritischen Erfolg erzielt (' + dice.join(', ') + ')! 🎉🥳🎆'); - return - } else if (countOccurrences(dice, 20) == 2) { - message.reply('Du hast einen Patzer (' + dice.join(', ') + ')! 😭 Viel Erfolg beim nächsten mal!') - return - } - if ((dice.length == 2 && dice[0] != 20 && dice[1] <= level) || (dice.length == 1 && dice[0] <= level)) { - if (attributename) { - message.reply('Du hast die Probe auf ' + attributename + ' (Stufe ' + level + ') bestanden.\n' + - 'Deine 🎲: ' + dice.join(', ')) - } else { - message.reply('Du hast die Probe (Stufe ' + level + ') bestanden.\n' + - 'Deine 🎲: ' + dice.join(', ')) - } - } else { - if (attributename) { - message.reply('Du hast die Probe auf ' + attributename + ' (Stufe ' + level + ') leider nicht bestanden 😢.\n' + - 'Deine 🎲: ' + dice.join(', ')) - } else { - message.reply('Du hast die Probe (Stufe ' + level + ') leider nicht bestanden 😢.\n' + - 'Deine 🎲: ' + dice.join(', ')) - } - } - }); - } catch (e) { - throw e; - } + return; + } + else { + // try to get id of short formatted attributes. + if (args[0].length == 2) { + for (const i in globals.Werte) { + if (globals.Werte[i].kuerzel == args[0].toUpperCase()) attributename = globals.Werte[i].id; + } + } + else { + attributename = args[0].toLowerCase(); + } + for (const i in docs[0].character.attributes) { + if (docs[0].character.attributes[i].id == attributename) level = docs[0].character.attributes[i].level; + } + } + } + else { + level = args[0]; + } + const countOccurrences = (arr, val) => arr.reduce((a, v) => (v === val ? a + 1 : a), 0); + const dice = []; + dice.push(Math.floor(Math.random() * 20) + 1); + if (dice[0] == 1 || dice[0] == 20) { + dice.push(Math.floor(Math.random() * 20) + 1); + } + // handle crits + if (countOccurrences(dice, 1) == 2) { + message.reply('Du hast einen kritischen Erfolg erzielt (' + dice.join(', ') + ')! 🎉🥳🎆'); + return; + } + else if (countOccurrences(dice, 20) == 2) { + message.reply('Du hast einen Patzer (' + dice.join(', ') + ')! 😭 Viel Erfolg beim nächsten mal!'); + return; + } + if ((dice.length == 2 && dice[0] != 20 && dice[1] <= level) || (dice.length == 1 && dice[0] <= level)) { + if (attributename) { + message.reply('Du hast die Probe auf ' + attributename + ' (Stufe ' + level + ') bestanden.\n' + + 'Deine 🎲: ' + dice.join(', ')); + } + else { + message.reply('Du hast die Probe (Stufe ' + level + ') bestanden.\n' + + 'Deine 🎲: ' + dice.join(', ')); + } + } + else if (attributename) { + message.reply('Du hast die Probe auf ' + attributename + ' (Stufe ' + level + ') leider nicht bestanden 😢.\n' + + 'Deine 🎲: ' + dice.join(', ')); + } + else { + message.reply('Du hast die Probe (Stufe ' + level + ') leider nicht bestanden 😢.\n' + + 'Deine 🎲: ' + dice.join(', ')); + } + }); + } + catch (e) { + throw e; + } }; \ No newline at end of file diff --git a/src/commands/index.js b/src/commands/index.js index c2525b3..a0c56e6 100644 --- a/src/commands/index.js +++ b/src/commands/index.js @@ -13,10 +13,10 @@ const kopf = require('./HeadsOrTails'); const zahl = require('./HeadsOrTails'); const heads = require('./HeadsOrTails'); const tails = require('./HeadsOrTails'); -const e = require('./attribute') -const ew = require('./attribute') -const a = require('./attribute') -const attr = require('./attribute') +const e = require('./attribute'); +const ew = require('./attribute'); +const a = require('./attribute'); +const attr = require('./attribute'); require('dotenv').config(); const cmdprefix = process.env.CMDPREFIX || '!'; @@ -37,7 +37,7 @@ const commands = { e, a, attr, - ew + ew, }; const Datastore = require('nedb'), @@ -47,7 +47,7 @@ const Datastore = require('nedb'), }); module.exports = async (message) => { - console.log(`${new Date().toUTCString()} ${message.author.tag} (size: ${message.attachments.size})`) + console.log(`${new Date().toUTCString()} ${message.author.tag} (size: ${message.attachments.size})`); if ((message.attachments.size > 0) && message.channel.type == 'dm' && !message.author.bot) { try { const response = await fetch(message.attachments.first().url); diff --git a/src/commands/remove.js b/src/commands/remove.js index bade26f..c83ffae 100644 --- a/src/commands/remove.js +++ b/src/commands/remove.js @@ -1,6 +1,6 @@ module.exports = async (message, args, db) => { - db.remove({ user: message.author.tag }, {}, function (err, numRemoved) { - message.reply('Ich habe deine Daten gelöscht.\n'+ - "Wenn dir danach ist, kannst du mir gerne wieder eine neue Datei zusenden.") + db.remove({ user: message.author.tag }, {}, function(err, numRemoved) { + message.reply('Ich habe deine Daten gelöscht.\n' + + 'Wenn dir danach ist, kannst du mir gerne wieder eine neue Datei zusenden.'); }); }; \ No newline at end of file diff --git a/src/commands/roll.js b/src/commands/roll.js index b6326a8..ccef856 100644 --- a/src/commands/roll.js +++ b/src/commands/roll.js @@ -1,21 +1,24 @@ // eslint-disable-next-line no-unused-vars module.exports = async (message, args, db) => { - let arguments = args.join('') - let regex = /\s?[DdWw]\s?/; + let msg; + let arguments = args.join(''); + const regex = /\s?[DdWw]\s?/; arguments = arguments.split(regex); - if (arguments.length == 2){ + if (arguments.length == 2) { let numberOfDice = arguments[0]; - let diceValues = arguments[1]; - let roll = []; - for (let i = 0; i W '); } - else { message.reply('Leider kann ich damit nichts anfangen. Bitte noch einmal so probieren:\n'+ - '!roll W ')} }; \ No newline at end of file diff --git a/src/commands/talent.js b/src/commands/talent.js index 1267353..9a763a8 100644 --- a/src/commands/talent.js +++ b/src/commands/talent.js @@ -15,17 +15,17 @@ module.exports = async (message, args, db) => { } const values = []; const roll = []; - let found = false + let found = false; let bonus = 0; let ok = 0; let patzer = 0; let crit = 0; for (i in docs[0].character.skills) { - if (docs[0].character.skills[i].id == args[0]) {bonus = docs[0].character.skills[i].level; found = true} + if (docs[0].character.skills[i].id == args[0]) {bonus = docs[0].character.skills[i].level; found = true;} } if (!found) { - message.reply('Sorry, das Talent ist mir unbekannt.') - return + message.reply('Sorry, das Talent ist mir unbekannt.'); + return; } const bonus_orig = bonus; const result = globals.Talente.find(talent => talent.id === args[0]); diff --git a/src/globals.js b/src/globals.js index 4d54f1b..b2e25d3 100644 --- a/src/globals.js +++ b/src/globals.js @@ -4,7 +4,7 @@ const money = [{ }]; -const Coin = ['Kopf','Zahl']; +const Coin = ['Kopf', 'Zahl']; const Werte = [ { id: 'mut', kuerzel: 'MU', name: 'Mut' }, { id: 'klugheit', kuerzel: 'KL', name: 'Klugheit' },